Fix error caused by double-locking repo #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
approved these changes
Jan 13, 2021
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
LGTM. Although it might be a good idea to pull fsrepo.Open out of the revertPins/transferPins functions and pass in the repo so that it's obvious we have the repo lock when we do mfsr.RepoPath(opts.Path).WriteVersion
aschmahmann
reviewed
Jan 14, 2021
aschmahmann
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #115.
The repo was being double-locked, once by the migration and once by opening the repo. However, on some platforms this double locking was not detected due to the combination of different locking implementations, and the defect was not detected by tests.