Update dnslink for dist.ipfs.io on merge to master #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Looks good, thank you 👍
Let's wait for DNSIMPLE_TOKEN to be set (pinged in https://github.com/protocol/infra/pull/760#pullrequestreview-768265453) and we should be good to go.
Before merge, we should make changes from comments below.
Mon, 04 Oct 2021 11:17:24 GMT make[1]: Entering directory '/build/dists/fs-repo-4-to-5' Mon, 04 Oct 2021 11:17:24 GMT ../../build-go.sh "fs-repo-4-to-5" "github.com/ipfs/fs-repo-migrations" "fs-repo-4-to-5" "versions" Mon, 04 Oct 2021 11:17:24 GMT comparing versions with /ipfs/QmTNL21g7x2eoDPuacpeYhrdiGnDi6aNbu3sMWH5e8JKLq/fs-repo-4-to-5/versions Mon, 04 Oct 2021 11:18:24 GMT Error: context deadline exceeded Mon, 04 Oct 2021 11:18:24 GMT make[1]: *** [../../common.mk:18: dist] Error 1 Checking if lack of routing system is responsible for the error.
lidel
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Thank you @petar!
I've tweaked CI to fix unrelated error (details in #417 (comment)) and made sure we expose secret and run DNSLink update only on master.
Will merge as soon lands https://github.com/protocol/infra/pull/760
lidel
changed the title
lidel
added a commit
that referenced
this pull request
Oct 4, 2021
* update dnslink for dist.ipfs.io on ci * fix(ci): context deadline exceeded * chore: cleanup before merge Co-authored-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
that referenced
this pull request
Oct 4, 2021
* update dnslink for dist.ipfs.io on ci * fix(ci): context deadline exceeded * chore: cleanup before merge Co-authored-by: Marcin Rataj <lidel@lidel.org>
|
@petar it worked in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #372.