-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move to the new LTS accross all projects #350
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -132,9 +132,16 @@ Always run tests before pushing and PR'ing your code. | |
|
||
#### Supported Versions | ||
|
||
IPFS projects support both the Current and Active LTS versions of Node.js. Please see [nodejs.org](https://nodejs.org/) for what these currently are. | ||
The IPFS JavaScript projects work with the most recent LTS of Node.js and respective npm version that gets installed with Node.js. Please consult [nodejs.org](https://nodejs.org/) for LTS timeline. Today these are: | ||
|
||
Browser code may be transpiled using Babel to take advantage of the latest JavaScript features. | ||
``` | ||
» date -u +"%Y-%m-%dT%H:%M:%SZ" | ||
2018-10-31T09:06:36Z | ||
» node -v | ||
v10.13.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we going to have to update this with every LTS point release? The idea behind saying 'Look at the node website for what the current LTS is' was to reduce the amount of busywork we have to do. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, we should not list the version here, it's easy to look up. |
||
» npm -v | ||
6.4.1 | ||
``` | ||
|
||
#### Linting & Code Style | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhpas doing a
date -u +"%Y-%m-%dT%H:%M:%SZ"
first, so that it is clear what "today" means?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done