Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitswap): use unique logger name for MessageQueue #632

Closed
wants to merge 1 commit into from

Conversation

Wondertan
Copy link
Member

bitwap is already taken by the root pkg and there is no way to access the MessageQueue logger

@Wondertan Wondertan requested a review from a team as a code owner June 27, 2024 17:38
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wondertan would you be up for unifying logger names in boxo/bitswap?

We seem to have mix of bs:foo and bitswap_foo.

Perhaps go with bitswap:foo everywhere?

@lidel lidel added the need/author-input Needs input from the original author label Jul 2, 2024
@gammazero
Copy link
Contributor

@lidel I think we should use bitswap/foo as that seems to be the typical convention in other parts of boxo..

I went ahead and made a PR to do that: #637. If that looks good we can use it in place of this.

@lidel
Copy link
Member

lidel commented Jul 9, 2024

Sgtm, let's continue in #637
Thank you for prompting this cleanup @Wondertan 👍

@lidel lidel closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants