generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway: remote blocks backend #594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
gateway-remote-blocks
branch
from
March 25, 2024 14:35
1cec5f5
to
afca373
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 60.61% 59.98% -0.63%
==========================================
Files 232 230 -2
Lines 27788 22196 -5592
==========================================
- Hits 16843 13315 -3528
+ Misses 9467 7407 -2060
+ Partials 1478 1474 -4
|
hacdias
force-pushed
the
gateway-remote-blocks
branch
from
March 25, 2024 15:04
4f4e412
to
8de9466
Compare
hacdias
force-pushed
the
gateway-remote-blocks
branch
from
March 25, 2024 15:06
8de9466
to
2ee6305
Compare
hacdias
force-pushed
the
gateway-remote-blocks
branch
from
April 2, 2024 12:04
2ee6305
to
2036531
Compare
hacdias
force-pushed
the
gateway-remote-blocks
branch
from
April 9, 2024 13:39
2036531
to
4bef702
Compare
lidel
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm, small nits below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #576: moves all remote blocks stuff to the gateway package, as well as the remote value store we used in the examples. It also includes the cached blockstore as well as the cached dns.
Moving the graph/CAR backend will be more complicated and involved. I will leave that for a separate PR.