fix: gateway panic because of overshadowed err #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 65.58% 65.53% -0.06%
==========================================
Files 207 207
Lines 25550 25553 +3
==========================================
- Hits 16758 16745 -13
- Misses 7319 7336 +17
+ Partials 1473 1472 -1
|
Jorropo
approved these changes
Nov 10, 2023
lidel
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects error handling in the
GetCARimplementation of the block backend.NOTE: sporadic panics, occurring during CAR requests under specific conditions, were harmless thanks to panic-recovery logic in the gateway handler, but created unnecessary noise in logs.