Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice & exchange & bitswap: add non variadic NotifyNewBlock #242

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Sep 28, 2024

  1. blockservice & exchange & bitswap: add non variadic NotifyNewBlock

    Variadicts in go are just syntactic sugar around passing a slice, that
    means all go memory reachability rules apply, this force the compiler to
    heap allocate the variadic slice for virtual call, because the
    implementation is allowed to leak the slice (and go's interprocedural
    optimisations do not cover virtuals).
    
    Passing a block without variadic will pass the itab either on the stack
    or decomposed through registers. Skipping having to allocate a slice.
    Jorropo authored and gammazero committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    323ef2c View commit details
    Browse the repository at this point in the history
  2. Update test interface

    gammazero committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    a76c8bd View commit details
    Browse the repository at this point in the history
  3. remove unused struct

    gammazero committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    fb743c0 View commit details
    Browse the repository at this point in the history
  4. update changelog

    gammazero committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    70c1906 View commit details
    Browse the repository at this point in the history
  5. doc updates

    gammazero committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    730b9bd View commit details
    Browse the repository at this point in the history