fix: remove busyloop in blockservice

ipfs · Mar 28, 2023 · 1cfd8cb · 1cfd8cb
1 parent 5bbb21b
commit 1cfd8cb
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/blockservice/blockservice.go b/blockservice/blockservice.go
@@ -296,6 +296,7 @@ func getBlocks(ctx context.Context, ks []cid.Cid, bs blockstore.Blockstore, fget
 		}
 
 		if !allValid {
+			// can't shift in place because we don't want to clobber callers.
 			ks2 := make([]cid.Cid, 0, len(ks))
 			for _, c := range ks {
 				// hash security
@@ -351,8 +352,6 @@ func getBlocks(ctx context.Context, ks []cid.Cid, bs blockstore.Blockstore, fget
 					batch = append(batch, b)
 				case <-ctx.Done():
 					return
-				default:
-					break batchLoop
 				}
 			}