fix!: check for missing production dependencies #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs the dep-check command twice - once omitting dev deps and only checking non-test code, then again but only testing test code. Should prevent future bugs similar to ipfs/helia-ipns#159
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Dec 30, 2023
Remove extra/add missing deps shown by ipfs/aegir#1426 Depends on #2339
3 tasks
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2024
## [42.0.0](v41.3.5...v42.0.0) (2024-01-06) ### ⚠ BREAKING CHANGES * previously undetected missing or unused deps will cause the dep-check command to fail ### Bug Fixes * check for missing production dependencies ([#1426](#1426)) ([a66384a](a66384a))
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jan 6, 2024
Remove extra/add missing deps shown by ipfs/aegir#1426 Upgrades aegir to 42.x.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the dep-check command twice - once omitting dev deps and only checking non-test code, then again but only testing test code.
depcheck is a bit wonky in that it doesn't support whitelisting files to check, only blacklisting so we pass a configurable list of ignore patterns that exclude known test files while checking prod deps and then a list of known prod files while checking dev deps.
Should prevent future bugs similar to ipfs/helia-ipns#159
BREAKING CHANGE: previously undetected missing or unused deps will cause the dep-check command to fail