Open
Conversation
add test for simple single planner and refactor filecoin v1 record provider
d96d6a5 to
29ee243
Compare
willscott
reviewed
Nov 12, 2021
Collaborator
willscott
left a comment
There was a problem hiding this comment.
The plan setup looks fine.
|
|
||
| var _ planning.RoutingRecordInterpreter = (*FilecoinV1RecordInterpreter)(nil) | ||
|
|
||
| type FilecoinV1RecordInterpreter struct { |
Collaborator
There was a problem hiding this comment.
do we have to call this filecoin records, rather than data-transfer/graphsync? which is the protocol spoken here?
masih
reviewed
Nov 12, 2021
Co-authored-by: Masih H. Derkani <m@derkani.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Implement an initial single planner, prepping to implement the larger planner
Implementation