Formatting Changes + Renames #27
Conversation
…tore This is fully compatible with the way go-ipfs tracks the filesystem datastore's size and unfortunately also contains quite a bit of code to work around concurrency-related limitations in their implementation.
…this Bonus: F821 is now fixed by pinning a newer pyflakes version.
…egates to the synchronous `__init__` `FileSystemDatastore` already overwrites this for instance, to provide its async-only construction method instead.
…tistics about the given datastore Includes handling for delegating to child datastores, particularily in situations where more than one child datastore may be present. Allowing callers to either provide a “selector” key to choose the backing store they are interested in or get the total size of all connected datastores.
(Cancellation handling in tiered is broken, so those tests fail in this commit.)
…/`stream.TeeingReceive*`
…iven key *prefix*
|
Damn. Style check failed. I will fix it today |
AliabbasMerchant
force-pushed
the
pr/24
branch
2 times, most recently
from
acfc93a to
d27217c
Compare
| mount_item_t = typing.Tuple['mount_tree_t[DS]', typing.Optional[DS]] | ||
|
|
||
|
|
||
| class mount_tree_t(typing.Dict[str, mount_item_t[DS]]): | ||
| ... | ||
|
|
There was a problem hiding this comment.
Yeah, that looks like a better solution. 👍
There was a problem hiding this comment.
@Alexander255 This change was made by you, not me. I hope you aren't going through all commits. Just go through the last 1-2 commits (the ones made by me)
|
I'm opposed to this, having a “locally namespaced” version of standard library modules When doing this, I actually took inspiration from our dependencies:
Could you explain which issues you encountered with the previous Also please rebase this, merging #24 appears to have made GitHub sad. 😉 |
|
It was mainly the issues I faced with my editor (PyCharm). It would recognise the If having same names for internal modules is not a matter of concern, then its okay with me. |
Lots of formatting changes [Including consistent spacing with tabs 😉]
Renamed the local
abctodatastore_abcandtypingtodatastore_typing, so as to help resolve imports unambiguously.