Bitswap 2.0.0. #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
requested changes
Sep 29, 2020
There was a problem hiding this comment.
I'm not deep enough into Bitswap to do a proper review (neither in the protocol, not in the code). The only things I'd like to bring up that I share @rklaehn's concern about naming it /ipfs/bitswap/2.0.0. I would expect /ipfs/bitswap versions being specified at https://github.com/ipfs/specs. So I would just use some different identifier in order to be future proof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4, closes #5, closes #6, closes #7