Feature: Alert bar for IPFS #289

pkafei · 2019-01-30T10:44:03Z

Announcement bar appears 2 hours before the weekly IPFS Weekly Call begins.

Notes:

Currently I'm toggling the alert bar using hide in jquery. In hindsight I probably should have used append or prepend in order to implement the toggling feature.
In the next version of the toggle bar, I would like the alert bar to turn red 15 minutes before the IPFS Weekly Call begins.
Interested in announcing other calls in the alert bar. That being said, not including the IPFS Cluster standups, we have about 9 public calls per week. I'm afraid our audience might suffer alert bar overload if we include an alert bar for every public call.
@daviddias @olizilla

Adding call info to the alert bar Encapsulated logic in function Hide alert bar Added call link

pkafei · 2019-01-31T17:46:36Z

@ipfs/infra Having trouble figuring out this Jenkins error- not sure what my next steps should be.

mikeal · 2019-02-11T19:11:07Z

Who do we need to loop in to review this?

daviddias · 2019-02-11T20:05:12Z

js/lib/alert-bar.js

@@ -0,0 +1,16 @@
+var $ = require('jquery')


Let's not import jquery just to create a pop up

http://youmightnotneedjquery.com/

@daviddias Jquery wouldn't be my first choice either, but it is already used in ipfs.io site. https://github.com/ipfs/website/blob/master/js/lib/popup.js https://github.com/ipfs/website/blob/master/js/lib/blog-feed.js

ya, we’re already using it on two other pages. if someone wants to send a PR to remove it’s use throughout the site, fine, but I don’t see why we would hold up new contributions since it’s not actually adding a dependency.

Jquery wouldn't be my first choice either, but it is already used in ipfs.io site.

Understood. Although I would argue that the best way to default not be the first choice anymore is to move away from it rather than adding it in more places.

daviddias · 2019-02-11T20:06:39Z

@pkafei I'm wondering how effective this popup banner would be. Did you study the analytics on the webpage to see if this is something that folks have open throughout the entire day or if it is common for folks to have the website open before the call?

A nice page presenting the Working Groups and Calls schedule could have more success as it would be a static resource that people could link to.

mikeal · 2019-02-11T21:33:32Z

I'm wondering how effective this popup banner would be. Did you study the analytics on the webpage to see if this is something that folks have open throughout the entire day or if it is common for folks to have the website open before the call?

We don’t really need analytics to tell us that people will see a message at the very top of the website. The reason it only appears during certain hours isn’t because we think people have the site up the entire time but because it’s not all that effective to try and get people to participate in the call when it’s nowhere near the time of the call.

The purpose of this bar is to drive participation in the weekly call. Analytics can tell us how many people it will address but the analytics can’t tell us if increasing participation in the call is worth above-the-fold website real estate, that’s a question we have to answer based on our own priorities. We’re working under the assumption that it is a priority, but if it’s not then we should have that discussion.

A nice page presenting the Working Groups and Calls schedule could have more success as it would be a static resource that people could link to.

We should definitely do this, but I don’t see how these are mutually exclusive. It was called out as a strategic goal back in Q4 to drive participation in this call specifically. Adding this to a list of calls for all of our working groups isn’t a great way to achieve that specific goal, although it’s a good idea and we should definitely do it.

If we’re going to lump any effort to drive participation in this call into a goal around participation in all of the calls then why do we have KPI’s and OKR’s associated with this call specifically, which actually pre-date @pkafei even working on this?

alanshaw · 2019-02-12T10:01:28Z

js/lib/alert-bar.js

+  var dayOfWeek = new Date().getDay()
+  var reminder = $('.alert-bar')
+  var announcement = $('.lh-title').append('<span>The IPFS community call will start at ' + callData.time + '. Join us <a href=' + callData.zoomLink + '>here</a></span>')
+  if ((startTime - now <= 2 && startTime - now >= 0) && (dayOfWeek === 1)) {


dayOfWeek === 1 should be tied to the day property of the data in communityCall.json right? Otherwise changes to the day for a call will still cause this banner to be displayed on Monday.

Good point. The call for the for seeable future will on Monday, but I really should be using the day property of communityCall.json which is better than just hard coding Monday.

alanshaw · 2019-02-12T10:08:06Z

js/lib/alert-bar.js

+  var dayOfWeek = new Date().getDay()
+  var reminder = $('.alert-bar')
+  var announcement = $('.lh-title').append('<span>The IPFS community call will start at ' + callData.time + '. Join us <a href=' + callData.zoomLink + '>here</a></span>')
+  if ((startTime - now <= 2 && startTime - now >= 0) && (dayOfWeek === 1)) {


Banner will disappear as soon as the call starts. Should we leave it up for the duration of the call? - maybe encode this information in the communityCall.json.

HI @alanshaw! Eric here (Proto-noob).

What if the message changed to, "The IPFS community call is now in progress! Join us here." once the call began, so latecomers could join?

Also, i would make the entire "Join us here." phrase a link.

What if the message changed to, "The IPFS community call is now in progress! Join us here." once the call began, so latecomers could join?

I like that suggestion. That being said, the link to landing page will still be the same so that participants will know that they're joining a live call.

js/lib/alert-bar.js

alanshaw · 2019-02-12T10:24:48Z

js/lib/communityCall.json

+    "callName": "IPFS Weekly Call",
+    "time": "17:00 UTC",
+    "day": "Monday",
+    "zoomLink": "https://protocol.zoom.us/j/443621844"


Given that the banner is going to be displayed 2 hours before the call is it better to link them to a page with more info about the call, which has the notes link as well as the zoom link? Otherwise people might be sat in an empty room for 2 hours.

Or link directly to the zoom when the call is happening, but to a "more information" page before?

Given that the banner is going to be displayed 2 hours before the call is it better to link them to a page with more info about the call, which has the notes link as well as the zoom link?Otherwise people might be sat in an empty room for 2 hours.

Yes, it would be better to link people to a "more information" page. Will swap out link for "more information page" ipfs/team-mgmt#549

olizilla · 2019-02-13T08:56:02Z

In general I am +1 for this change. Minor UI tweaks to do. Threre are a bunch of related changes so I'd be happy to talk it through when you have a moment @pkafei

We can simplify the alert bar and improve the vertical alignment of the icon and the text by swapping out flex for plain old vertical-align. The info icon looks a little low relative to the text.
Swapping out .lh-title on the span for .lh-copy on the container, so that the same line hight is used for both the icon and the text, and when we view the site on a narrow / mobile screen it is a little more readable when the text wraps.
Let's progressively enhance; we can hide the alert bar by default with a style="display:none;" and flip the js logic to only show the alert bar if it's time. Right now JS hides the alert bar if it's not time, so if the js bundle takes a while to load (or js is disabled), the user will see the alert bar regardless of the time.

pkafei · 2019-02-27T11:25:51Z

Please review my PR again. @alanshaw @ipfs/wg-gui-team @olizilla

olizilla · 2019-02-27T11:29:53Z

Will do. I'm gonna sort out CI right now so we can get a preview URL on this PR, then I'll review.

alanshaw · 2019-02-28T09:43:44Z

js/lib/communityCall.json

@@ -0,0 +1,7 @@
+{
+    "callName": "IPFS Weekly Call",
+    "time": "18:00 UTC",


The weekly call is at 17:00 UTC.

alanshaw · 2019-02-28T09:58:26Z

js/lib/alert-bar.js

+  var startTime = parseInt(callData.time, 10)
+  var dayOfWeek = new Date().getUTCDay()
+  var reminder = $('.alert-bar')
+  if ((startTime - now <= 2 && startTime - now >= 0.5) && (dayOfWeek === callData.day)) {


I think you need some tests here, this will still hide the banner while the call is in progress.

Locally the banner still appears while the call is in session on my machine- but will add test.

olizilla

Some tweaks for the call info page

olizilla · 2019-03-19T13:56:44Z

js/lib/test.js

+var callData = require('./communityCall.json')
+var shouldShowBanner = require('./alert-bar').shouldShowBanner
+
+var dayOfWeek = callData.day


dayOfWeek, startTime, two_hours_before_call and dayOfWeek are no longer used in these tests. Please remove.

olizilla · 2019-03-19T13:58:37Z

content/ipfs-call/index.md

+
+## Welcome to the IPFS Weekly Call
+
+Join us every week for the IPFS Weekly Call where we hear from the IPFS Community. We use zoom to host our calls and [this link](https://protocol.zoom.us/j/443621844) will directly bring you into the live video chat.


This call info page should probably say when the call is, in case you find your way to it at some time that the call isnt on.

olizilla · 2019-03-19T14:01:02Z

content/ipfs-call/index.md

+Before you join there are several points we would like to go over:
+
+1. The IPFS calls are recorded and are put on [Youtube](https://www.youtube.com/playlist?list=PLuhRWgmPaHtSGRSHdU9dbsukHKlihZZAe)
+2. Please sign into the [IPFS Weekly Call sheet](https://docs.google.com/document/d/1WHyIZhBo2eEgYXlZ5HLHg6a6ZWTH3tV848sWkYBJjJA/edit#heading=h.hz5t61tdc5r6)


Suggested change

2. Please sign into the [IPFS Weekly Call sheet](https://docs.google.com/document/d/1WHyIZhBo2eEgYXlZ5HLHg6a6ZWTH3tV848sWkYBJjJA/edit#heading=h.hz5t61tdc5r6)

2. Have a read of the agenda for the call, and add your name as an attendee on the [IPFS Weekly Call document](https://docs.google.com/document/d/1WHyIZhBo2eEgYXlZ5HLHg6a6ZWTH3tV848sWkYBJjJA/edit#heading=h.hz5t61tdc5r6)

olizilla · 2019-03-19T14:03:29Z

content/ipfs-call/index.md

+
+1. The IPFS calls are recorded and are put on [Youtube](https://www.youtube.com/playlist?list=PLuhRWgmPaHtSGRSHdU9dbsukHKlihZZAe)
+2. Please sign into the [IPFS Weekly Call sheet](https://docs.google.com/document/d/1WHyIZhBo2eEgYXlZ5HLHg6a6ZWTH3tV848sWkYBJjJA/edit#heading=h.hz5t61tdc5r6)
+


We expect all participants to abide by the Code of Conduct.

…#295

olizilla · 2019-03-21T10:54:35Z

js/lib/alert-bar.js

+  var startTime = parseInt(callData.time, 10)
+  var dayOfWeek = new Date().getUTCDay()
+  var reminder = $('.alert-bar')
+  if ((startTime - now <= 2 && startTime - now >= parseFloat(-0.5) && (dayOfWeek === callData.day))) {


@pkafei the callTime function should use shouldShowBanner to determine if it should show or hide the banner. right now it duplicates the logic, which is risky, as the test will suggest that the logic is correct but we're not testing the function that will actually be run when the user loads the page.

Suggested change

if ((startTime - now <= 2 && startTime - now >= parseFloat(-0.5) && (dayOfWeek === callData.day))) {

if (shouldShowBanner(new Date(), callData.time, callData.day)) {

That also means that callTime no longer needs to declare the now, startTime and dayOfWeek variables.

olizilla · 2019-03-21T11:02:45Z

js/lib/alert-bar.js

+  var startTime = parseInt(startTimeString, 10)
+  var dayOfWeek = date.getUTCDay()
+
+  console.log(now, startTime, dayOfWeek)


It's good form to remove all debug logging from code before we ship it. Please delete this line.

jessicaschilling · 2019-08-26T19:58:33Z

@olizilla -- this is a stale issue but still sounds like a good idea. What do you think -- and might you have time to implement the changes you'd originally requested, in order to ship?

jessicaschilling · 2019-12-16T20:29:27Z

Closing this issue, since IPFS website has changed in scope/purpose since issue opened. Let's keep this concept in mind as we discuss redeveloping IPFS website as a whole.

pkafei added 5 commits January 29, 2019 17:19

Feature: Add a reminder bar two hours before the IPFS Weekly Call

23a2cd6

Adding call info to the alert bar Encapsulated logic in function Hide alert bar Added call link

More changes

6d60aa2

Alert bar will only appear on Mondays

30184c0

Switched time positions in conditional

10683d2

Minor verbiage edits

0225fa8

pkafei mentioned this pull request Feb 11, 2019

Proposal: Use a Zoom Landing Page for public calls ipfs/team-mgmt#549

Open

mikeal requested review from daviddias and a team February 11, 2019 19:45

daviddias reviewed Feb 11, 2019

View reviewed changes

daviddias requested review from a team and removed request for a team February 11, 2019 20:06

alanshaw suggested changes Feb 12, 2019

View reviewed changes

daviddias requested a review from a team February 13, 2019 08:55

Alert bar only appears between 16pm-18:30pm UTC

158c1ff

ghost assigned pkafei Feb 20, 2019

ghost added the in progress label Feb 20, 2019

pkafei added 4 commits February 21, 2019 12:32

Alert bar does not show by default

4c293b2

Added call page

05d3ef5

Merge remote-tracking branch 'upstream/master'

ea3aeca

Alert bar now links to call page

af6f23b

alanshaw suggested changes Feb 28, 2019

View reviewed changes

Added test

417a793

olizilla suggested changes Mar 19, 2019

View reviewed changes

pkafei added 3 commits March 19, 2019 19:41

Implemented tweaks

b846dce

Addressed lint warnings

d3c8c1c

Increase color contrast for text links in alert, closes ipfs-inactive…

409d3be

…#295

olizilla suggested changes Mar 21, 2019

View reviewed changes

Refactor logic for callTime function

26f4baf

jessicaschilling added topic/docs Documentation topic/design-front-end Front-end implementation of UX/UI work OKR: Hotfixes and removed in progress labels Aug 26, 2019

jessicaschilling mentioned this pull request Aug 26, 2019

Announcing Community Syncs on IPFS Website #286

Closed

jessicaschilling assigned olizilla and unassigned pkafei Aug 26, 2019

jessicaschilling added Category: Content and removed Q319: Hotfixes labels Sep 26, 2019

jessicaschilling closed this Dec 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Alert bar for IPFS #289

Feature: Alert bar for IPFS #289

pkafei commented Jan 30, 2019 •

edited

Loading

pkafei commented Jan 31, 2019

mikeal commented Feb 11, 2019

daviddias Feb 11, 2019

pkafei Feb 11, 2019 •

edited

Loading

mikeal Feb 11, 2019

daviddias Feb 13, 2019

daviddias commented Feb 11, 2019

mikeal commented Feb 11, 2019 •

edited

Loading

alanshaw Feb 12, 2019

pkafei Feb 12, 2019

alanshaw Feb 12, 2019

ericronne Feb 28, 2019

pkafei Mar 4, 2019

alanshaw Feb 12, 2019

pkafei Feb 12, 2019

olizilla commented Feb 13, 2019 •

edited

Loading

pkafei commented Feb 27, 2019 •

edited

Loading

olizilla commented Feb 27, 2019

alanshaw Feb 28, 2019

alanshaw Feb 28, 2019

pkafei Mar 6, 2019

olizilla left a comment

olizilla Mar 19, 2019

olizilla Mar 19, 2019

olizilla Mar 19, 2019

olizilla Mar 19, 2019

olizilla Mar 21, 2019

olizilla Mar 21, 2019

jessicaschilling commented Aug 26, 2019

jessicaschilling commented Dec 16, 2019


		## Welcome to the IPFS Weekly Call

		Join us every week for the IPFS Weekly Call where we hear from the IPFS Community. We use zoom to host our calls and [this link](https://protocol.zoom.us/j/443621844) will directly bring you into the live video chat.

	2. Please sign into the [IPFS Weekly Call sheet](https://docs.google.com/document/d/1WHyIZhBo2eEgYXlZ5HLHg6a6ZWTH3tV848sWkYBJjJA/edit#heading=h.hz5t61tdc5r6)
	2. Have a read of the agenda for the call, and add your name as an attendee on the [IPFS Weekly Call document](https://docs.google.com/document/d/1WHyIZhBo2eEgYXlZ5HLHg6a6ZWTH3tV848sWkYBJjJA/edit#heading=h.hz5t61tdc5r6)


		1. The IPFS calls are recorded and are put on [Youtube](https://www.youtube.com/playlist?list=PLuhRWgmPaHtSGRSHdU9dbsukHKlihZZAe)
		2. Please sign into the [IPFS Weekly Call sheet](https://docs.google.com/document/d/1WHyIZhBo2eEgYXlZ5HLHg6a6ZWTH3tV848sWkYBJjJA/edit#heading=h.hz5t61tdc5r6)

	if ((startTime - now <= 2 && startTime - now >= parseFloat(-0.5) && (dayOfWeek === callData.day))) {
	if (shouldShowBanner(new Date(), callData.time, callData.day)) {

Feature: Alert bar for IPFS #289

Feature: Alert bar for IPFS #289

Conversation

pkafei commented Jan 30, 2019 • edited Loading

pkafei commented Jan 31, 2019

mikeal commented Feb 11, 2019

Choose a reason for hiding this comment

pkafei Feb 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias commented Feb 11, 2019

mikeal commented Feb 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olizilla commented Feb 13, 2019 • edited Loading

pkafei commented Feb 27, 2019 • edited Loading

olizilla commented Feb 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olizilla left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessicaschilling commented Aug 26, 2019

jessicaschilling commented Dec 16, 2019

pkafei commented Jan 30, 2019 •

edited

Loading

pkafei Feb 11, 2019 •

edited

Loading

mikeal commented Feb 11, 2019 •

edited

Loading

olizilla commented Feb 13, 2019 •

edited

Loading

pkafei commented Feb 27, 2019 •

edited

Loading