Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

fix: addFromURL case #415

Merged
merged 1 commit into from
Dec 11, 2018
Merged

fix: addFromURL case #415

merged 1 commit into from
Dec 11, 2018

Conversation

@alanshaw
Copy link
Contributor

@alanshaw alanshaw commented Dec 10, 2018

Inconsistently addFromUrl in some places...

fix: addFromURL case
b246086 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@ghost ghost assigned alanshaw Dec 10, 2018
@ghost ghost added the in progress label Dec 10, 2018
@alanshaw alanshaw mentioned this pull request Dec 10, 2018
Merged
achingbrain
achingbrain approved these changes Dec 11, 2018
View reviewed changes
Copy link
Collaborator

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw alanshaw merged commit f54422d into master Dec 11, 2018
@ghost ghost removed the in progress label Dec 11, 2018
@alanshaw alanshaw deleted the fix/addFromURL-case branch December 11, 2018 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

2 more reviewers

@achingbrain achingbrain achingbrain approved these changes

@daviddias daviddias daviddias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alanshaw alanshaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alanshaw @achingbrain @daviddias