Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/use old client repo when create market client #353

Merged

Conversation

LinZexiao
Copy link
Collaborator

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao requested a review from simlecode June 26, 2023 08:07
@LinZexiao LinZexiao changed the base branch from master to release/v2.8 June 26, 2023 08:08
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.8@f95344a). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/v2.8     #353   +/-   ##
===============================================
  Coverage                ?   20.78%           
===============================================
  Files                   ?      190           
  Lines                   ?    23098           
  Branches                ?        0           
===============================================
  Hits                    ?     4800           
  Misses                  ?    17516           
  Partials                ?      782           
Flag Coverage Δ
unittests 20.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 5ac5e97 into release/v2.8 Jun 26, 2023
@simlecode simlecode deleted the fix/use-OldClientRepo-when-create-market-client branch June 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants