Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unified run mode #244

Closed
wants to merge 1 commit into from

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Nov 24, 2022

关联的Issues (Related Issues)

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen self-assigned this Nov 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.5.0-pre-rc1@709ab8d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 70e5489 differs from pull request most recent head 6395091. Consider uploading reports for the commit 6395091 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##             release/v2.5.0-pre-rc1     #244   +/-   ##
=========================================================
  Coverage                          ?   24.85%           
=========================================================
  Files                             ?      183           
  Lines                             ?    21185           
  Branches                          ?        0           
=========================================================
  Hits                              ?     5266           
  Misses                            ?    15098           
  Partials                          ?      821           
Flag Coverage Δ
unittests 24.85% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@diwufeiwen diwufeiwen marked this pull request as draft November 24, 2022 08:06
@diwufeiwen diwufeiwen force-pushed the feat/lt/unified_run_mode branch 2 times, most recently from 70e5489 to 6395091 Compare November 25, 2022 05:31
@diwufeiwen diwufeiwen marked this pull request as ready for review November 25, 2022 06:23
@diwufeiwen diwufeiwen closed this Nov 25, 2022
@diwufeiwen diwufeiwen reopened this Nov 25, 2022
@diwufeiwen diwufeiwen force-pushed the feat/lt/unified_run_mode branch 2 times, most recently from ebacb64 to 060cf06 Compare November 30, 2022 07:14
@diwufeiwen diwufeiwen closed this Dec 1, 2022
@diwufeiwen diwufeiwen deleted the feat/lt/unified_run_mode branch December 2, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants