Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): fix cargo cache #540

Merged
merged 1 commit into from
Dec 12, 2022
Merged

chore(CI): fix cargo cache #540

merged 1 commit into from
Dec 12, 2022

Conversation

0x5459
Copy link
Contributor

@0x5459 0x5459 commented Dec 4, 2022

关联的Issues (Related Issues)

ref #214

改动 (Proposed Changes)

  • venus-worker CI 缓存整个 ~/.cargo 目录。避免重复编译工作
  • 保护分支开启 push 触发 ci。主要用于生成缓存,也能保证保护分支的代码是通过ci的。
  • venus-worker-util 移除了action 缓存。venus-worker-util 编译速度比较快,移除缓存节约缓存的空间。

尝试 sccache 后编译速度提升不明显,所以放弃 sccache。

附注 (Additional Info)

参考:

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合 Venus 项目管理规范中关于 PR 的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@0x5459 0x5459 force-pushed the chore/0x5459/try_sccache branch 2 times, most recently from eb59eb3 to 86fe2d9 Compare December 4, 2022 10:49
@0x5459 0x5459 mentioned this pull request Dec 5, 2022
42 tasks
@0x5459 0x5459 changed the title chore(CI): try sccache chore(CI): try Swatinem/rust-cache Dec 5, 2022
@0x5459 0x5459 changed the title chore(CI): try Swatinem/rust-cache chore(CI): try sccache Dec 5, 2022
@0x5459 0x5459 force-pushed the chore/0x5459/try_sccache branch 2 times, most recently from 45ff338 to 88e604f Compare December 9, 2022 09:10
@0x5459 0x5459 marked this pull request as ready for review December 9, 2022 09:19
@0x5459 0x5459 requested a review from dtynn December 9, 2022 09:19
@0x5459 0x5459 changed the title chore(CI): try sccache chore(CI): fix cargo cache Dec 11, 2022
@0x5459 0x5459 requested review from dtynn and removed request for dtynn December 11, 2022 20:05
Copy link
Contributor

@dtynn dtynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5459 0x5459 merged commit 151099e into main Dec 12, 2022
@0x5459 0x5459 deleted the chore/0x5459/try_sccache branch December 12, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants