Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create a list of examples #27

Merged
merged 6 commits into from
Apr 6, 2023
Merged

docs: create a list of examples #27

merged 6 commits into from
Apr 6, 2023

Conversation

whizzzkid
Copy link
Contributor

@whizzzkid whizzzkid commented Apr 4, 2023 •
edited
Loading

Addresses: ipfs/helia#35

In this PR:

@whizzzkid whizzzkid requested a review from SgtPooki April 4, 2023 07:33
@whizzzkid whizzzkid mentioned this pull request Apr 4, 2023
Merged
@achingbrain achingbrain changed the title fix(docs): ✨ Creating a list of examples. docs: ✨ Creating a list of examples. Apr 4, 2023
@whizzzkid whizzzkid mentioned this pull request Apr 4, 2023
Open
24 tasks
@achingbrain achingbrain changed the title docs: ✨ Creating a list of examples. docs: Creating a list of examples. Apr 5, 2023
@achingbrain achingbrain changed the title docs: Creating a list of examples. docs: create a list of examples. Apr 5, 2023
achingbrain
achingbrain requested changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small edits to remove the passive voice and also break the examples up into themed sections.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
whizzzkid and others added 2 commits April 5, 2023 21:03
@whizzzkid @achingbrain
Update README.md
868a777 
Co-authored-by: Alex Potsides <alex@achingbrain.net>
@whizzzkid @achingbrain
Update README.md
40a8a68 
Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain
achingbrain reviewed Apr 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@achingbrain achingbrain changed the title docs: create a list of examples. docs: create a list of examples Apr 6, 2023
@achingbrain achingbrain merged commit e9453c3 into main Apr 6, 2023
@achingbrain achingbrain deleted the fix/docs-pre-release-v1 branch April 6, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

@SgtPooki SgtPooki Awaiting requested review from SgtPooki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whizzzkid @achingbrain