Skip to content

improve logic #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

improve logic #9

merged 1 commit into from
Mar 25, 2021

Conversation

@etam
Copy link
Contributor

@etam etam commented Jan 21, 2021

  • if one address fails to resolve, then continue
  • properly handle multiple oldcids

Stebalien
Stebalien requested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to pin the new version before unpinning the old version in case something fails. But also note: these scripts are not currently used (this repo is for archiving old scripts).

@etam
Copy link
Contributor Author

etam commented Mar 24, 2021 •
edited
Loading

But also note: these scripts are not currently used (this repo is for archiving old scripts).

Definitely I'm using it as written in description: "for archiving and pinning things on Clusters". Is there anything similar actively maintained and used?

@etam etam requested a review from Stebalien March 25, 2021 20:36
Stebalien
Stebalien approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bash is strong with this one, it is.

@Stebalien Stebalien merged commit 91d8eb8 into ipfs-cluster:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@etam @Stebalien