Foremand supervisor dotenv fix #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipepe
reviewed
Nov 14, 2023
ipepe
reviewed
Nov 14, 2023
| private | ||
|
|
||
| def load_dotenv_if_present(app_env) | ||
| return "-e #{APP_ROOT}/.env.#{app_env}" if File.exist?("#{APP_ROOT}/.env.#{app_env}") |
Owner
There was a problem hiding this comment.
That looks good, can you also add support for .env.#{app_env}.local?
Author
There was a problem hiding this comment.
Added per suggestion, but I have changed the order to match https://github.com/bkeepers/dotenv#what-other-env-files-can-i-use
.env.x.local takes precedence over .env.x
ipepe
reviewed
Nov 14, 2023
Co-authored-by: Patryk Ptasiński <github@ipepe.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.