fix(R5Process) log error in R console before throwing #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #515 runtime errors from the little jar are exceptionally unhelpful.
R5Process.run()
which is the abstract method for all for all of the methods in R5. I've placed a try catch statement to LOG the traceback in the R console through our existing logging system when an error is caught.I believe this simple change will actually solve most of the problems. For example in the issue opened by Matt, the rjava error thrown is a
ExecutionException
. The only code that throws an ExceutionException in the little jar isR5Process.run()
so that error would now come with a java stack trace making debugging easier.