Skip to content

Add max_iterations to Additive CCD #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add max_iterations to Additive CCD #145

merged 1 commit into from
Dec 3, 2024

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Dec 3, 2024

Description

Add max_iterations parameter to Additive CCD.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves existing functionality)

Checklist

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zfergus zfergus merged commit 75ef144 into main Dec 3, 2024
30 checks passed
@zfergus zfergus deleted the accd branch December 3, 2024 18:59
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.69%. Comparing base (e0b947c) to head (9dc4df5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/ccd/additive_ccd.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   96.73%   96.69%   -0.04%     
==========================================
  Files         109      109              
  Lines        7740     7742       +2     
==========================================
- Hits         7487     7486       -1     
- Misses        253      256       +3     
Flag Coverage Δ
unittests 96.69% <77.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

antoinebou12 pushed a commit to ETSim/ipc-toolkit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant