Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup in ipbus_transport_multibuffer_if.vhd to avoid Vivado synthesis 'critical warning' #164

Closed
jhegeman opened this issue Feb 19, 2020 · 1 comment · Fixed by #165
Closed

Minor cleanup in ipbus_transport_multibuffer_if.vhd to avoid Vivado synthesis 'critical warning' #164

jhegeman opened this issue Feb 19, 2020 · 1 comment · Fixed by #165
Milestone
Release 1.8

Comments

@jhegeman
Copy link
Contributor

Vivado (and `ipbb check-syntax) produce 'critical warnings' along these lines:

CRITICAL WARNING: [HDL 9-3240] actual for formal port 'addra' is neither a static name nor a globally static expression 
```
for two port assignments in `ipbus_transport_multibuffer_if.vhd`.  These are simple to clean up.
jhegeman added a commit to jhegeman/ipbus-firmware that referenced this issue Feb 19, 2020
@jhegeman
References IPbus issue ipbus#164. Just a tiny patch to make all port …
1524ac6 
…assignments obey true VHDL syntax in order to avoid Vivado producing 'critical warnings.'
tswilliams added a commit that referenced this issue Feb 20, 2020
@tswilliams
Merge pull request #165 from jhegeman/ipbus_issue_164
ae02557 
This should fix IPbus issue #164.
@tswilliams
Copy link
Collaborator

Fix has been merged in (pull request #165). Closing.

@tswilliams tswilliams linked a pull request May 15, 2020 that will close this issue
This should fix IPbus issue #164. #165
Merged
@tswilliams tswilliams added this to the Release 1.8 milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.8
Development

Successfully merging a pull request may close this issue.

This should fix IPbus issue #164. jhegeman/ipbus-firmware
2 participants
@jhegeman @tswilliams