Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipbus_freq_ctr_div entity is named just freq_ctr_div #109

Closed
alessandrothea opened this issue May 2, 2019 · 1 comment
Closed

ipbus_freq_ctr_div entity is named just freq_ctr_div #109

alessandrothea opened this issue May 2, 2019 · 1 comment

Comments

@alessandrothea
Copy link
Collaborator

Nothing particularly wrong with it except for the fact that all other slave's names are prefixed with ipbus_ (and the .vhd file as well)

@tswilliams
Copy link
Collaborator

Following a discussion about naming conventions at the end of last year: We should not add the ipbus_ prefix to the entity name - since none of the ports are ipbus records. Instead we should remove ipbus_ from the file's name, to match the entity name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants