This repository was archived by the owner on Nov 26, 2021. It is now read-only.
use utf8mb4 for names and altnames#17
Open
nitper wants to merge 1 commit intoipalaus:masterfrom
brightjobs:utf8mb4
Open
use utf8mb4 for names and altnames#17nitper wants to merge 1 commit intoipalaus:masterfrom brightjobs:utf8mb4
nitper wants to merge 1 commit intoipalaus:masterfrom
brightjobs:utf8mb4
Conversation
Owner
|
@nitper sorry for the delay, looks that we need to import illumiante/support in order to make the tests pass. Use the facade Do you wanna push it and check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alternate_names data has utf8 characters that are longer than 3 bytes, so we need to change the character encoding and collation to
utf8mb4- see here and here. This is a fix that requires mysql >= 5.5This is the error you get with
utf8: