Skip to content

Deployment support ros2#175

Merged
NadiaHG merged 5 commits into
ipa320:masterfrom
ipa-rwu:rwu/feature/ros2_compose
Nov 24, 2021
Merged

Deployment support ros2#175
NadiaHG merged 5 commits into
ipa320:masterfrom
ipa-rwu:rwu/feature/ros2_compose

Conversation

@ipa-rwu

@ipa-rwu ipa-rwu commented Nov 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@ipa-nhg

  • Support deployment for ros2
    • generate dockerfile for rossystem or ros stacks
    • create compose file (without setting network for now. DDS still can work without docker network)
    • fix naming issue, e.g. folder name, image name, folder path, workflow name
    • examples:
      • system test case is here
      • stack test case is here

NadiaHG
NadiaHG approved these changes Nov 24, 2021
View reviewed changes

@NadiaHG NadiaHG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ✔️
Local test for system composed by components ✔️
Local test for system composed by stacks ✔️
CI tests ✔️

Thanks a lot @ipa-rwu! great job!

@NadiaHG NadiaHG merged commit 6b5d18a into ipa320:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NadiaHG NadiaHG NadiaHG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ipa-rwu @NadiaHG