Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbpf-tools:Fix bitesize dependency on kernel version #5234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiraskyler
Copy link
Contributor

@kiraskyler kiraskyler commented Mar 17, 2025

tracepoint block_rq_iss was modified in v5.10.137

v5.10.137 include/trace/events/block.h
v5.10.136 include/trace/events/block.h

from:

DEFINE_EVENT(block_rq, block_rq_issue,

	TP_PROTO(struct request_queue *q, struct request *rq),

	TP_ARGS(q, rq)
);

to:

DEFINE_EVENT(block_rq, block_rq_issue,

	TP_PROTO(struct request *rq),

	TP_ARGS(rq)
);

The contents of the parentheses refer to this change to a commit message with a link.

libbpf-tools/core_fixes.bpf.h: 84

/**
 * commit d152c682f03c ("block: add an explicit ->disk backpointer to the
 * request_queue") and commit f3fa33acca9f ("block: remove the ->rq_disk
 * field in struct request") make some changes to `struct request` and
 * `struct request_queue`. Now, to get the `struct gendisk *` field in a CO-RE
 * way, we need both `struct request` and `struct request_queue`.
 * see:
 *     https://github.com/torvalds/linux/commit/d152c682f03c
 *     https://github.com/torvalds/linux/commit/f3fa33acca9f
 */

tracepoint block_rq_issue changed from 5.10.137, not 5.11

Signed-off-by: niuwanli <niuwanli@cqsoftware.com.cn>
@kiraskyler
Copy link
Contributor Author

The CI/CD error doesn't seem to be related to pr, can you help me?
@rtomayko @ragnard @calavera @badboy

@badboy
Copy link
Contributor

badboy commented Mar 17, 2025

The CI/CD error doesn't seem to be related to pr, can you help me? [...]@badboy

What is it these days with getting mentioned randomly on issues I have no connection to?
This isn't my project, so I have no idea how you came to ping me.
In general it's not the nicest way to just ping some random people on a bug.

You send a PR, if CI fails leave a comment and wait for reviewers/repo owners to take a look. There's no need to explicitly ping people.

@kiraskyler
Copy link
Contributor Author

The CI/CD error doesn't seem to be related to pr, can you help me? [...]@badboy

What is it these days with getting mentioned randomly on issues I have no connection to? This isn't my project, so I have no idea how you came to ping me. In general it's not the nicest way to just ping some random people on a bug.

You send a PR, if CI fails leave a comment and wait for reviewers/repo owners to take a look. There's no need to explicitly ping people.

Sorry about that,I typed @ and github recommended you, thanks for the reply and have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants