hardirqs: Optimize output information and increase CPU display #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine the previous count and time into one, and increase CPU independent statistics and maximum interrupt time Before: ./hardirqs Tracing hard irq event time... Hit Ctrl-C to end. ^C HARDIRQ TOTAL_usecs enp0s3 254 snd_intel8x0 368 ./hardirqs -C Tracing hard irq events... Hit Ctrl-C to end. ^C HARDIRQ TOTAL_count enp0s3 14 ata_piix 2 After: ./hardirqs Tracing hard irq event time... Hit Ctrl-C to end. ^C HARDIRQ CPU TOTAL_count TOTAL_usecs MAX_usecs ata_piix - 2 32 21 enp0s3 - 19 318 42 ./hardirqs -C Tracing hard irq event time... Hit Ctrl-C to end. ^C HARDIRQ CPU TOTAL_count TOTAL_usecs MAX_usecs enp0s3 2 111375 1420732 303 enp0s3 9 1546 21826 39 ata_piix 8 8 162 33 Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
kknjh
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
| @@ -42,7 +42,7 @@ const char *argp_program_bug_address = | |||
| const char argp_program_doc[] = | |||
| "Summarize hard irq event time as histograms.\n" | |||
| "\n" | |||
| "USAGE: hardirqs [--help] [-T] [-N] [-d] [interval] [count] [-c CG]\n" | |||
| "USAGE: hardirqs [--help] [-T] [-N] [-d] [interval] [-C] [-c CG]\n" | |||
There was a problem hiding this comment.
Please do not replace '[count]' with '[-C]'.
I know you want to add a CPU column for the output. What is your use case? How does this help you for production investigation?
There was a problem hiding this comment.
I didn't replace count with CPU, I just changed count to default display. Count, total time, and max time will all be displayed. Increasing CPU can observe whether the interrupt distribution is balanced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the previous count and time into one,
and increase CPU independent statistics and maximum interrupt time
Before:
./hardirqs
Tracing hard irq event time... Hit Ctrl-C to end.
^C
HARDIRQ TOTAL_usecs
enp0s3 254
snd_intel8x0 368
./hardirqs -C
Tracing hard irq events... Hit Ctrl-C to end.
^C
HARDIRQ TOTAL_count
enp0s3 14
ata_piix 2
After:
./hardirqs
Tracing hard irq event time... Hit Ctrl-C to end.
^C
HARDIRQ CPU TOTAL_count TOTAL_usecs MAX_usecs
ata_piix - 2 32 21
enp0s3 - 19 318 42
./hardirqs -C
Tracing hard irq event time... Hit Ctrl-C to end.
^C
HARDIRQ CPU TOTAL_count TOTAL_usecs MAX_usecs
enp0s3 2 111375 1420732 303
enp0s3 9 1546 21826 39
ata_piix 8 8 162 33