examples/tracing/disksnoop.py: Fix kprobe attaching failure #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issues/5124: "Exception:Failed to attach BPF program ..." by attaching the function blk_mq_end_request blk_account_io_done became inline function since kernel v5.16 and blk_account_io_done has been taken off since v6.4. With this change, only when the code runs on a legacy kernel these *_io_done functions will be attached, otherwise it goes for blk_mq_end_request.
we3i
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #5124 "Exception:Failed to attach BPF program ..." by attaching the function blk_mq_end_request
blk_account_io_donebecame inline function since kernel v5.16 andblk_account_io_donehas been taken off since v6.4. With this change, only when the code runs on a legacy kernel these*_io_donefunctions will be attached, otherwise it goes forblk_mq_end_request.