bcc: Update perf buffer C++ API #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhengqi
requested review from
4ast,
davemarchevsky,
drzaeus77 and
yonghong-song
as code owners
davemarchevsky
requested changes
Jan 17, 2022
src/cc/api/BPFTable.cc
Outdated
| return StatusTuple(-1, "Perf buffer already open on CPU %d", cpu); | ||
| StatusTuple BPFPerfBuffer::open_on_cpu(perf_reader_raw_cb cb, perf_reader_lost_cb lost_cb, | ||
| void* cb_cookie, int page_cnt, | ||
| struct bcc_perf_buffer_opts *opts) { |
There was a problem hiding this comment.
can you add a null pointer check for opts here, or make it a reference?
There was a problem hiding this comment.
OK, make it a reference.
Like in iovisor#3801 and iovisor#3805, this patch adds a consume API which allows user to force reading from perf buffer and adds wake_events parameter on open_all_cpu API. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
chenhengqi
force-pushed
the
update-perf-buffer
branch
from
8961cda to
a517668
Compare
davemarchevsky
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in #3801 and #3805, this patch adds a consume API
which allows user to force reading from perf buffer and
adds wake_events parameter on open_all_cpu API.
Signed-off-by: Hengqi Chen chenhengqi@outlook.com