Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcc: Update perf buffer C++ API #3817

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

chenhengqi
Copy link
Collaborator

Like in #3801 and #3805, this patch adds a consume API
which allows user to force reading from perf buffer and
adds wake_events parameter on open_all_cpu API.

Signed-off-by: Hengqi Chen chenhengqi@outlook.com

return StatusTuple(-1, "Perf buffer already open on CPU %d", cpu);
StatusTuple BPFPerfBuffer::open_on_cpu(perf_reader_raw_cb cb, perf_reader_lost_cb lost_cb,
void* cb_cookie, int page_cnt,
struct bcc_perf_buffer_opts *opts) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a null pointer check for opts here, or make it a reference?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, make it a reference.

Like in iovisor#3801 and iovisor#3805, this patch adds a consume API
which allows user to force reading from perf buffer and
adds wake_events parameter on open_all_cpu API.

Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
@davemarchevsky davemarchevsky merged commit 3ac3c5d into iovisor:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants