-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fedora docker tests + move dockerfiles to a new dir #3778
add fedora docker tests + move dockerfiles to a new dir #3778
Conversation
35afea3
to
3d143c4
Compare
Dockerfiles are cluttering up the main repo dir, so move them to a newly-created 'docker' dir. Add a fedora dockerfile and use it in bcc-test workflow.
3d143c4
to
ddfedaa
Compare
I'm going to merge this, but for now will not add the fedora tests to the list of "Required" tests that block merge. There are some issues that should be addressed before the fedora tests can be considered at parity with the Ubuntu tests:
/cc @yonghong-song |
I think the bullet point about failing lua tests was incorrect. On Ubuntu, the bcc build step says:
While on Fedora:
If LuaJIT is not found, Lua tests will not be run (see |
@@ -94,6 +94,86 @@ jobs: | |||
name: critical-tests-${{ matrix.env['TYPE'] }}-${{ matrix.os.version }} | |||
path: tests/python/critical.log | |||
|
|||
test_bcc_fedora: | |||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_bcc_fedora and runs-on ubuntu-20.04? I do see we are using Dockerfile.fedora
below. So ubuntu-20.04
is a copy-paste error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is intentional. ubuntu-20.04
here describes the OS of the "GitHub actions runner" VM. List of supported runner OS's here doesn't include fedora.
The docker container is Fedora, though. So aside from the kernel still being ubuntu-20.04
's, tests are running using userspace and toolchains of Fedora.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for ubuntu run:
Could NOT find LuaJIT (missing: LUAJIT_LIBRARIES LUAJIT_INCLUDE_DIR)
luajit package may be missing in the system. Will need to figure how to get the package properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is intentional.
ubuntu-20.04
here describes the OS of the "GitHub actions runner" VM. List of supported runner OS's here doesn't include fedora.The docker container is Fedora, though. So aside from the kernel still being
ubuntu-20.04
's, tests are running using userspace and toolchains of Fedora.
Okay, utunbu vm and fedora docker container. Make sense. thanks for explanation.
Dockerfiles are cluttering up the main repo dir, so move them to a
newly-created 'docker' dir.
Add a fedora dockerfile and use it in bcc-test workflow.