cmake: always link to packaged libbpf if CMAKE_USE_LIBBPF_PACKAGE is set #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluca
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
[buildbot, test this please] |
|
CMake's NAME_WLE was introduced in v3.14, changed to NAME_WE which is available in older releases. Let's see if this works or it needs permissions: |
|
[buildbot, test this please] |
1 similar comment
|
[buildbot, test this please] |
|
[buildbot, ok to test] |
Some of the executables still link to the local static versions even if the user requested CMAKE_USE_LIBBPF_PACKAGE. Fix this by using bcc-shared-no-libbpf more widely if the variable is set.
…PF_PACKAGE is set Skip the git submodule and the extraction commands if the user set CMAKE_USE_LIBBPF_PACKAGE
|
The build failure on the Ubuntu CIs was due to the order of linker flags being changed - on some compilers it matters. I've fix it and restored the original order - bpf-static first, then its dependencies (elf/zlib). |
|
@yonghong-song gentle ping for review. We will be using these patches in the upcoming Debian 11 release (and as a consequence in the next Ubuntu release and other derivatives). TIA! |
|
The change looks good to me. Thanks! |
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
…set (iovisor#3210) Some of the executables still link to the local static versions even if the user requested CMAKE_USE_LIBBPF_PACKAGE. Fix this by using bcc-shared-no-libbpf more widely if the variable is set. Skip the git submodule and the extraction commands if the user set CMAKE_USE_LIBBPF_PACKAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some binaries, even if CMAKE_USE_LIBBPF_PACKAGE is set static linking is still used, breaking expectations. If the option to use the packaged version is set, it should be respected.