Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -DCMAKE_INSTALL_PREFIX=/usr as the default #2800

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

gfx
Copy link
Contributor

@gfx gfx commented Mar 8, 2020

It is a typical mistake to mix adding "-DCMAKE_INSTALL_PREFIX=/usr " and not when we develop BCC.

Let's set the right default and forget the option.

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

This makes sense as /usr probably is a sensible and most people just use it. Further people can always provide their own install prefix if needed.

@yonghong-song yonghong-song merged commit 4c1136e into iovisor:master Mar 18, 2020
@gfx gfx deleted the install_to_usr_as_default branch March 18, 2020 07:04
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
* make -DCMAKE_INSTALL_PREFIX=/usr as the default
* remove -DCMAKE_INSTALL_PEREFIX=/usr from INSTALL.md  as it gets the default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants