Fixes #2518 -- weird behaviour of lookup_or_init #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the current function)
…g in the test runner. Also fixed a bug in libbcc where the python signature did not match the actual implementation.
pjsg
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
[buildbot, test this please] |
|
[buildbot, ok to test] |
|
Thanks! The change looks good to me. |
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
* Allow lookup_or_init to return NULL (rather than just returning from the current function) * Fixed a couple of bad edits found when running tests. Also fixed a bug in the test runner. Also fixed a bug in libbcc where the python signature did not match the actual implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of
map.lookup_or_initso that it returns 0 if the entry is not found and it cannot be inserted (e.g. the map is full). #2518Documentation updated. Also, all tests and sample code updated.
During testing, found two errors in test setup -- one was a mismatch between a function prototype and the libbcc python definition, and the other was an incorrect python path in the test wrapper.
I can't actually get all the tests to pass on my platform -- but the same set of tests fail on master, so I'm not unduly worried. I didn't understand the test failures -- but they look like a failure to setup the test environment.