-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iovisor/bcc] trace: Incorrect symbol offsets when using build_id (#2161) #2162
Conversation
Added build_id support for BPF stackmap. A separate build_id stackmap can be created with the help of new macro BPF_STACK_TRACE_BUILDID The kernel BPF reports stacktrace in the structure bpf_stack_build_id. Changes have been made to BPF modules to support resolving symbols mentioned in the above format. An example tool is also available in tools/stack_buildid_example.py
New command line options have been added to tools/trace.py to support the new BUILD_ID stackmap. List of symbol files can be added to the script to resolve symbols from build id as reported by the kernel in the stack trace Updated man page and added an example usage
…d of offset from start of the symbol
@vijunag the majority of changes already in trunk. Could you rebase your change to the trunk and resubmit? Thanks. |
|
@vijunag The following is what I typically do:
Periodically you need to With the Your work can then rebase on top of the latest code. |
@yonghong-song - Can you check once now ? Only the changes appear now. |
[buildbot, test this please] |
@sandip4n could you check whether this patch fixed the issue or not? Thanks! |
@yonghong-song Apologies for the delay. This works as expected now. Thanks @vijunag |
* master: (609 commits) docs: references_guide.md: add/fix search examples/tools links (iovisor#2186) Fix misc file permissions (iovisor#2185) sync with latest bpf (iovisor#2184) sync with latest libbpf repo (iovisor#2183) docs: fix broken link of bpf_log2l(iovisor#2176) examples/tracing: some minor fixes Fix tools/syscount -l (iovisor#2180) examples/tracing/bitehist.py: add example of linear histogram (iovisor#2177) cachestat: bring back HITRATIO column Fix debuginfo search on Ubuntu Add installation instructions for Amazon Linux 1 AMI Sign-Off-By Travis Davies <trdavies@amazon.com> [iovisor/bcc] trace: Incorrect symbol offsets when using build_id (iovisor#2161) (iovisor#2162) profile: exclude CPU idle stacks by default (iovisor#2166) fix cpuunclaimed.py with cfs_rq structure change (iovisor#2164) tools: rename "deadlock_detector" to "deadlock" (iovisor#2152) (iovisor#2160) use libbpf api in bpf_attach_xdp (iovisor#2158) support symbol resolution of short-lived process. (iovisor#2144) profile.py: return kernel annotations for folded stacks use libbpf APIs from libbpf.c (iovisor#2156) ddos_detector.py to monitor DDOS attacks (iovisor#2140) ...
…visor#2161) (iovisor#2162) Fix iovisor#2161 - bcc_bsymcache API returned absolute address instead of offset from start of the symbol
…visor#2161) (iovisor#2162) Fix iovisor#2161 - bcc_bsymcache API returned absolute address instead of offset from start of the symbol
bcc_bsym_resolve API returned absolute address instead of offset from start of the function.