Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: software update using hawkbit over HTTPS #582

Merged
merged 2 commits into from
Jan 11, 2024
Merged

ESP32: software update using hawkbit over HTTPS #582

merged 2 commits into from
Jan 11, 2024

Conversation

Danielius1922
Copy link
Member

No description provided.

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (2d7f858), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 16, 2023
View reviewed changes
port/esp32/adapter/include/oc_certificates.h Outdated
"-----BEGIN EC PARAMETERS-----\n"
"BggqhkjOPQMBBw==\n"
"-----END EC PARAMETERS-----\n"
"-----BEGIN EC PRIVATE KEY-----\n"

Check failure

Code scanning / SonarCloud

Cryptographic private keys should not be disclosed

<!--SONAR_ISSUE_KEY:AYx0YZmurXhtmpukTYn5-->Make sure this private key gets revoked, changed, and removed from the code. <p>See more on <a href="https://sonarcloud.io/project/issues?id=iotivity_iotivity-lite&issues=AYx0YZmurXhtmpukTYn5&open=AYx0YZmurXhtmpukTYn5&pullRequest=582">SonarCloud</a></p>
@Danielius1922 Danielius1922 force-pushed the adam/feature/mbedtls3_5_0 branch from 65489e8 to fabe5f4 Compare December 18, 2023 11:36
Base automatically changed from adam/feature/mbedtls3_5_0 to master December 18, 2023 12:34
@Danielius1922 Danielius1922 force-pushed the adam/feature/hawkbit branch 4 times, most recently from 5bf42ff to 49ba5ca Compare December 18, 2023 15:50
jkralik
jkralik reviewed Jan 8, 2024
View reviewed changes
port/esp32/main/main.c Outdated Show resolved Hide resolved
jkralik
jkralik reviewed Jan 8, 2024
View reviewed changes
port/esp32/main/main.c Outdated Show resolved Hide resolved
@Danielius1922 Danielius1922 force-pushed the adam/feature/hawkbit branch 4 times, most recently from a609379 to 42740e7 Compare January 9, 2024 15:22
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Jan 11, 2024
@jkralik jkralik marked this pull request as ready for review January 11, 2024 07:32
jkralik
jkralik approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@jkralik jkralik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :). 👍

@Danielius1922
Refactor oc_sec_cred_t
1c303a0 
- fix issues reported by SonarCloud
- add oc_cred_serialize function to serialize selected certificates
to PEM string
@Danielius1922
ESP32: software update using hawkbit over HTTPS
cbe2b65
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Jan 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

78.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Danielius1922 Danielius1922 merged commit f74b116 into master Jan 11, 2024
122 of 123 checks passed
@Danielius1922 Danielius1922 deleted the adam/feature/hawkbit branch January 11, 2024 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkralik jkralik jkralik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Danielius1922 @jkralik