Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: print logs when a connection will been closed for error #496

Merged
merged 2 commits into from
Aug 20, 2023
Merged

tls: print logs when a connection will been closed for error #496

merged 2 commits into from
Aug 20, 2023

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Aug 17, 2023

No description provided.

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (087ae12), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@jkralik jkralik force-pushed the jkralik/fix/logs-msgs branch 3 times, most recently from c06a36c to a433c5c Compare August 17, 2023 09:05
@jkralik jkralik changed the title print proper logs messages tls: print logs when a connection will been closed for error Aug 17, 2023
@jkralik jkralik requested a review from Danielius1922 August 17, 2023 09:36
@jkralik jkralik marked this pull request as ready for review August 17, 2023 09:36
@jkralik jkralik added the OCF Conformance Testing OCF Conformance Testing required label Aug 17, 2023
Danielius1922
Danielius1922 reviewed Aug 17, 2023
View reviewed changes
security/oc_certs.c Outdated Show resolved Hide resolved
Danielius1922
Danielius1922 reviewed Aug 17, 2023
View reviewed changes
security/oc_tls.c Outdated Show resolved Hide resolved
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Aug 17, 2023
@jkralik jkralik added the OCF Conformance Testing OCF Conformance Testing required label Aug 18, 2023
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Aug 18, 2023
@jkralik jkralik force-pushed the jkralik/fix/logs-msgs branch 2 times, most recently from f6c3e58 to c6f2ce9 Compare August 18, 2023 11:42
Danielius1922
Danielius1922 reviewed Aug 18, 2023
View reviewed changes
security/oc_tls.c Outdated
static int
oc_tls_load_identity_cert_chain(mbedtls_ssl_config *conf, size_t device,
int credid)
#ifndef OC_TEST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just put the declaration outside the OC_TEST ifdef in the header. oc_tls_validate_identity_certs_consistency and oc_tls_validate_trust_anchors_consistency declarations are ifdef-ed in the header because the definitions exist only with OC_TEST, otherwise internal functions have declarations in internal headers to be available for tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jkralik jkralik force-pushed the jkralik/fix/logs-msgs branch 4 times, most recently from 950880e to 5f944b2 Compare August 19, 2023 11:00
@jkralik jkralik added the OCF Conformance Testing OCF Conformance Testing required label Aug 19, 2023
@jkralik jkralik force-pushed the jkralik/fix/logs-msgs branch from 6b48361 to 3164dd7 Compare August 19, 2023 12:59
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Aug 19, 2023
@jkralik jkralik added the OCF Conformance Testing OCF Conformance Testing required label Aug 19, 2023
@jkralik jkralik force-pushed the jkralik/fix/logs-msgs branch from 3164dd7 to 747da8d Compare August 20, 2023 07:11
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Aug 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.7% 82.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jkralik jkralik added the OCF Conformance Testing OCF Conformance Testing required label Aug 20, 2023
@jkralik jkralik merged commit 13e05b6 into master Aug 20, 2023
@jkralik jkralik deleted the jkralik/fix/logs-msgs branch August 20, 2023 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Danielius1922 Danielius1922 Danielius1922 approved these changes

Assignees
No one assigned
Labels
OCF Conformance Testing OCF Conformance Testing required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkralik @Danielius1922