Fix runtime disabling of logging #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the internal representation from an unsigned to a signed integer. The value OC_LOG_LEVEL_DISABLED (=-1) is now to disable logging during runtime. Whether a log level is enabled is checked by the '<' operator. Previously, when casting to uint8_t, the value overflowed to 255, causing all log levels to be enabled. This issue has been resolved by using a signed integer representation.
|
🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed. ℹ️ To verify your latest change (87ac6d4), label this PR with |
jkralik
approved these changes
Jun 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the internal representation from an unsigned to a signed integer. The value OC_LOG_LEVEL_DISABLED (=-1) is now to disable logging during runtime. Whether a log level is enabled is checked by the '<' operator. Previously, when casting to uint8_t, the value overflowed to 255, causing all log levels to be enabled. This issue has been resolved by using a signed integer representation.