Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: refactor event callbacks #458

Merged
merged 5 commits into from
Jun 6, 2023
Merged

api: refactor event callbacks #458

merged 5 commits into from
Jun 6, 2023

Conversation

Danielius1922
Copy link
Member

  • move to standalone file
  • fix SonarCloud issues
  • add tests

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (ed567e6), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/feature/434-fix-time-adjustment-timed-events branch 4 times, most recently from e4eab67 to 5214fa3 Compare June 5, 2023 08:46
@Danielius1922 Danielius1922 force-pushed the adam/feature/434-fix-time-adjustment-timed-events branch from 5214fa3 to b3eeca5 Compare June 5, 2023 10:50
@Danielius1922 Danielius1922 force-pushed the adam/feature/434-fix-time-adjustment-timed-events branch 2 times, most recently from 6a52276 to eec3f8a Compare June 6, 2023 08:38
@Danielius1922 Danielius1922 marked this pull request as ready for review June 6, 2023 08:45
@Danielius1922 Danielius1922 requested a review from jkralik June 6, 2023 08:45
@Danielius1922 Danielius1922 force-pushed the adam/feature/434-fix-time-adjustment-timed-events branch from eec3f8a to 350f558 Compare June 6, 2023 09:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Jun 6, 2023
@Danielius1922 Danielius1922 merged commit 0e58efa into master Jun 6, 2023
@Danielius1922 Danielius1922 deleted the adam/feature/434-fix-time-adjustment-timed-events branch June 6, 2023 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkralik jkralik jkralik approved these changes

Assignees
No one assigned
Labels
OCF Conformance Testing OCF Conformance Testing required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Danielius1922 @jkralik