Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code smells reported by SonarCloud in test code (2) #369

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

Danielius1922
Copy link
Member

No description provided.

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.


ℹ️ To verify your latest change (896b72c), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/feature/sc-fixes-6 branch 4 times, most recently from 258446f to 8ec08aa Compare February 5, 2023 10:35
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Feb 5, 2023
@Danielius1922 Danielius1922 force-pushed the adam/feature/sc-fixes-6 branch from 8ec08aa to 40a3b1e Compare February 6, 2023 17:57
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Feb 6, 2023
@Danielius1922 Danielius1922 force-pushed the adam/feature/sc-fixes-6 branch 3 times, most recently from 9048a57 to 5db90e8 Compare February 6, 2023 21:46
@Danielius1922 Danielius1922 force-pushed the adam/feature/sc-fixes-6 branch from 5db90e8 to fe960bf Compare February 6, 2023 21:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@Danielius1922 Danielius1922 marked this pull request as ready for review February 6, 2023 23:27
@Danielius1922 Danielius1922 merged commit 191e05f into master Feb 6, 2023
@Danielius1922 Danielius1922 deleted the adam/feature/sc-fixes-6 branch February 6, 2023 23:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant