Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SonarCloud workflow #306

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Update SonarCloud workflow #306

merged 1 commit into from
Aug 30, 2022

Conversation

Danielius1922
Copy link
Member

sonnar-scanner currently doesn't handle multi configuration
compilation. Thus if a file is compiled multiple times (such is
the case for files in the api folder) then only the first
compilation of such a file is analysed. So the best we can do
is enable as many features as possible and compile target in
such an order to get most of the code analysis (ie. compile
client-server target first, so we get analysis with both
OC_CLIENT and OC_SERVER defined)

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.


ℹ️ To verify your latest change (d89a437), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 requested a review from joochlee August 30, 2022 09:06
@Danielius1922 Danielius1922 marked this pull request as ready for review August 30, 2022 09:07
sonnar-scanner currently doesn't handle multi configuration
compilation. Thus if a file is compiled multiple times (such is
the case for files in the api folder) then only the first
compilation of such a file is analysed. So the best we can do
is enable as many features as possible and compile target in
such an order to get most of the code analysis (ie. compile
client-server target first, so we get analysis with both
OC_CLIENT and OC_SERVER defined)
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/fix-sc-job branch from d89a437 to fa69b0b Compare August 30, 2022 09:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@joochlee
Copy link
Collaborator

Hi Daniel,

This patch looks reasonable to me, so merge this patch please.
Once it is merged, I'll try my codes with this again.

@Danielius1922
Copy link
Member Author

Danielius1922 commented Aug 30, 2022

Hi Daniel,

This patch looks reasonable to me, so merge this patch please. Once it is merged, I'll try my codes with this again.

You need to give an Approve! :D Otherwise the merge is blocked. Go to the Files Changed tab, click on the "Review Changes" button and select Approve.

Copy link
Collaborator

@joochlee joochlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good! 👍

@Danielius1922 Danielius1922 merged commit 8771a8c into master Aug 30, 2022
@Danielius1922 Danielius1922 deleted the adam/bugfix/fix-sc-job branch August 30, 2022 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants