SonarCloud: don't use variable tainted by fread

iotivity · Sep 26, 2023 · eede00d · eede00d
1 parent 43443b6
commit eede00d
Show file tree

Hide file tree

Showing 11 changed files with 29 additions and 17 deletions.
diff --git a/api/oc_server_api.c b/api/oc_server_api.c
@@ -506,7 +506,9 @@ oc_add_collection_v1(oc_resource_t *collection)
 void
 oc_add_collection(oc_resource_t *collection)
 {
-  oc_add_collection_v1(collection);
+  if (!oc_add_collection_v1(collection)) {
+    OC_ERR("failed to add collection");
+  }
 }
 
 oc_resource_t *

diff --git a/apps/client_certification_tests.c b/apps/client_certification_tests.c
@@ -603,7 +603,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/apps/cloud_certification_tests.c b/apps/cloud_certification_tests.c
@@ -544,7 +544,7 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (pem_len > (long)*buffer_len) {
+  if (pem_len >= (long)*buffer_len) {
     OC_PRINTF("ERROR: buffer provided too small\n");
     fclose(fp);
     return -1;
@@ -554,7 +554,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/apps/cloud_client.c b/apps/cloud_client.c
@@ -315,7 +315,7 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (pem_len > (long)*buffer_len) {
+  if (pem_len >= (long)*buffer_len) {
     OC_PRINTF("ERROR: buffer provided too small\n");
     fclose(fp);
     return -1;
@@ -325,7 +325,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/apps/cloud_proxy.c b/apps/cloud_proxy.c
@@ -1634,7 +1634,7 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (pem_len > (long)*buffer_len) {
+  if (pem_len >= (long)*buffer_len) {
     OC_PRINTF("ERROR: buffer provided too small\n");
     fclose(fp);
     return -1;
@@ -1644,7 +1644,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/apps/cloud_server.c b/apps/cloud_server.c
@@ -828,7 +828,7 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (pem_len > (long)*buffer_len) {
+  if (pem_len >= (long)*buffer_len) {
     OC_PRINTF("ERROR: buffer provided too small\n");
     fclose(fp);
     return -1;
@@ -838,7 +838,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/apps/server_certification_tests.c b/apps/server_certification_tests.c
@@ -2023,7 +2023,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/apps/smart_home_server_linux.c b/apps/smart_home_server_linux.c
@@ -737,7 +737,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     printf("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/apps/smart_home_server_with_mock_swupdate.cpp b/apps/smart_home_server_with_mock_swupdate.cpp
@@ -272,7 +272,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/onboarding_tool/obtmain.c b/onboarding_tool/obtmain.c
@@ -1760,7 +1760,7 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (pem_len > (long)*buffer_len) {
+  if (pem_len >= (long)*buffer_len) {
     OC_PRINTF("ERROR: buffer provided too small\n");
     fclose(fp);
     return -1;
@@ -1770,7 +1770,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;

diff --git a/python/oc_python.c b/python/oc_python.c
@@ -1492,7 +1492,7 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (pem_len > (long)*buffer_len) {
+  if (pem_len >= (long)*buffer_len) {
     OC_PRINTF("[C]ERROR: buffer provided too small\n");
     fclose(fp);
     return -1;
@@ -1502,7 +1502,8 @@ read_pem(const char *file_path, char *buffer, size_t *buffer_len)
     fclose(fp);
     return -1;
   }
-  if (fread(buffer, 1, pem_len, fp) < (size_t)pem_len) {
+  size_t to_read = (size_t)pem_len;
+  if (fread(buffer, 1, to_read, fp) < (size_t)pem_len) {
     OC_PRINTF("[C]ERROR: unable to read PEM\n");
     fclose(fp);
     return -1;