Skip to content

Fix contract staking index checking #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+31 −29
Open

Fix contract staking index checking #4753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8adadb
still check contract index after xingu
envestcc Nov 14, 2025
91faa62
check index in parallel
envestcc Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 31 additions & 29 deletions action/protocol/staking/protocol.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,8 @@ func (p *Protocol) Start(ctx context.Context, sr protocol.StateReader) (protocol
}
}
c.contractsStake = &contractStakeView{}
if p.skipContractStakingView(height) {
return c, nil
}

wg := sync.WaitGroup{}
errChan := make(chan error, 3)
checker := blockdao.GetChecker(ctx)
checkIndex := func(indexer ContractStakingIndexer) error {
checker := blockdao.GetChecker(ctx)
if checker == nil {
return nil
}
Expand Down Expand Up @@ -301,38 +295,46 @@ func (p *Protocol) Start(ctx context.Context, sr protocol.StateReader) (protocol
}
return checker.CheckIndexer(ctx, indexer, height, func(h uint64) {
if h%5000 == 0 || h == height {
log.L().Info("Checking contract staking indexer", zap.Uint64("height", h))
log.L().Info("Checking contract staking indexer", zap.Uint64("height", h), zap.String("contract", indexer.ContractAddress().String()))
}
})
}
buildView := func(indexer ContractStakingIndexer, callback func(ContractStakeView)) {
if indexer == nil {
return
// List of all indexers to process
indexers := []struct {
indexer ContractStakingIndexer
setter func(ContractStakeView)
}{
{p.contractStakingIndexer, func(v ContractStakeView) { c.contractsStake.v1 = v }},
{p.contractStakingIndexerV2, func(v ContractStakeView) { c.contractsStake.v2 = v }},
{p.contractStakingIndexerV3, func(v ContractStakeView) { c.contractsStake.v3 = v }},
}
// Process all indexers in parallel
wg := sync.WaitGroup{}
errChan := make(chan error, len(indexers))
skipView := p.skipContractStakingView(height)
for _, idx := range indexers {
if idx.indexer == nil {
continue
}
wg.Add(1)
go func() {
go func(indexer ContractStakingIndexer, setter func(ContractStakeView)) {
defer wg.Done()
// First, checking the indexer
if err := checkIndex(indexer); err != nil {
errChan <- errors.Wrap(err, "failed to check contract staking indexer")
errChan <- errors.Wrapf(err, "failed to check contract staking indexer %s", indexer.ContractAddress())
return
}
view, err := NewContractStakeViewBuilder(indexer, p.blockStore).Build(ctx, sr, height)
if err != nil {
errChan <- errors.Wrapf(err, "failed to create stake view for contract %s", indexer.ContractAddress())
return
// If not skipping view creation, build the view
if !skipView {
view, err := NewContractStakeViewBuilder(indexer, p.blockStore).Build(ctx, sr, height)
if err != nil {
errChan <- errors.Wrapf(err, "failed to create stake view for contract %s", indexer.ContractAddress())
return
}
setter(view)
}
callback(view)
}()
}
buildView(p.contractStakingIndexer, func(view ContractStakeView) {
c.contractsStake.v1 = view
})
buildView(p.contractStakingIndexerV2, func(view ContractStakeView) {
c.contractsStake.v2 = view
})
buildView(p.contractStakingIndexerV3, func(view ContractStakeView) {
c.contractsStake.v3 = view
})
}(idx.indexer, idx.setter)
}
wg.Wait()
close(errChan)
for err := range errChan {
Expand Down