Slash candidate test #4716
Open
Slash candidate test #4716
+152
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
reviewed
Sep 29, 2025
action/protocol/staking/protocol.go
Outdated
| if err := csm.updateBucket(bucket.Index, bucket); err != nil { | ||
| return errors.Wrapf(err, "failed to update bucket %d", bucket.Index) | ||
| } | ||
| prevWeightedVotes := p.calculateVoteWeight(bucket, true) |
There was a problem hiding this comment.
why calculate pre votes after bucket amount deducted?
envestcc
reviewed
Sep 29, 2025
| return errors.Wrapf(state.ErrStateNotExist, "candidate %s does not exist", owner.String()) | ||
| } | ||
| bucket, err := p.fetchBucket(csm, candidate.SelfStakeBucketIdx) | ||
| if err != nil { |
There was a problem hiding this comment.
the slashed candidate may be already unstaked
CoderZhi
force-pushed
the
slash_candidate_test
branch
from
1d29309 to
a80f3fc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jump to 1d29309 to review
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: