[blockchain] add ValidateBlock() to fullsync check #4566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc and
a team
as code owners
|
CoderZhi
reviewed
Feb 24, 2025
| for i, indexer := range dao.indexers { | ||
| if _, ok := indexer.(BlockIndexerStateDBWriter); ok { | ||
| checker = NewBlockIndexerChecker(dao, dao.validator) |
There was a problem hiding this comment.
why do we need to validate every block again in the indexers?
There was a problem hiding this comment.
re-validation should only be required for the fullsync scenario
There was a problem hiding this comment.
added flag to do this only for fullsync mode/check
dustinxie
force-pushed
the
valfull
branch
3 times, most recently
from
39a4ed9 to
6544f38
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as title, so fullsync runs the same check as sync blocks from network.
Fixes #4561
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: