[action] simplify TxCommon interface #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc and
a team
as code owners
dustinxie
commented
Nov 19, 2024
| @@ -71,6 +70,7 @@ type ( | |||
| TxDynamicGas interface { | |||
| GasTipCap() *big.Int | |||
| GasFeeCap() *big.Int | |||
| EffectiveGasPrice(*big.Int) *big.Int | |||
There was a problem hiding this comment.
more natural to put the func in TxDynamicGas
dustinxie
commented
Nov 19, 2024
| @@ -387,7 +387,7 @@ func (p *Protocol) deleteStateV2(sm protocol.StateManager, key []byte) error { | |||
| func (p *Protocol) settleSystemAction( | |||
| ctx context.Context, | |||
| sm protocol.StateManager, | |||
| act action.TxCommon, | |||
| act action.TxDynamicGas, | |||
There was a problem hiding this comment.
#4396 extends this interface to TxCommon, with this change, we can reduce it back to TxDynamicGas
envestcc
approved these changes
Nov 20, 2024
Liuhaai
approved these changes
Nov 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as title.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: