[api] refactor call param parsing #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
CoderZhi
approved these changes
Nov 11, 2024
dustinxie
reviewed
Nov 20, 2024
api/web3server.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| from, to, gasLimit, gasPrice, value, data := callMsg.From, callMsg.To, callMsg.Gas, callMsg.GasPrice, callMsg.Value, callMsg.Data |
There was a problem hiding this comment.
from, to := callMsg.From, callMsg.To
the other 4 can directly use callMsg.xxx at L457 below
dustinxie
reviewed
Nov 20, 2024
api/web3server.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| callerAddr, contractAddr, gasLimit, value, callData = callMsg.From, callMsg.To, callMsg.Gas, callMsg.Value, callMsg.Data |
There was a problem hiding this comment.
same here, can directly use callMsg.xxx at L1136
1 task
|
huangzhiran
approved these changes
Nov 29, 2024
dustinxie
pushed a commit
that referenced
this pull request
Dec 2, 2024
dustinxie
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as title
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: