Revert "[iip-15]sgdRegistry implementation (#3845) " #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc and
a team
as code owners
dustinxie
added a commit
that referenced
this pull request
Aug 8, 2024
dustinxie
changed the title
dustinxie
added a commit
that referenced
this pull request
Aug 8, 2024
envestcc
approved these changes
Aug 9, 2024
guo
approved these changes
Aug 9, 2024
dustinxie
added a commit
that referenced
this pull request
Aug 9, 2024
dustinxie
added a commit
that referenced
this pull request
Aug 10, 2024
CoderZhi
reviewed
Aug 12, 2024
Comment on lines
+313
to
+316
| if forTest { | ||
| builder.cs.sgdIndexer = nil | ||
| return nil | ||
| } | ||
| kvStore, err := db.CreateKVStoreWithCache(builder.cfg.DB, builder.cfg.Chain.SGDIndexDBPath, 1000) | ||
| if err != nil { | ||
| return err | ||
| } else { | ||
| builder.cs.sgdIndexer = blockindex.NewSGDRegistry() |
There was a problem hiding this comment.
delete the whole function?
There was a problem hiding this comment.
will be done in next PR
| GetBlockTime: getBlockTime, | ||
| GetBlockHash: dao.GetBlockHash, | ||
| GetBlockTime: getBlockTime, | ||
| DepositGasFunc: rewarding.DepositGasWithSGD, |
There was a problem hiding this comment.
will be done in next PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As dicussed, revert the SGD implementation. This is the first PR to revert SGD registry/indexer. A second PR will revert the change inside EVM
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: