[contract_indexer] fix transfer event handling #3887
Conversation
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
envestcc
force-pushed
the
bugfix_transfer
branch
from
8b95e35 to
3340c2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3887 +/- ##
==========================================
+ Coverage 75.38% 75.39% +0.01%
==========================================
Files 303 328 +25
Lines 25923 27812 +1889
==========================================
+ Hits 19541 20968 +1427
- Misses 5360 5767 +407
- Partials 1022 1077 +55
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -434,7 +434,15 @@ func (eh *contractStakingEventHandler) handleTransferEvent(event eventParam) err | |||
| return err | |||
| } | |||
|
|
|||
| eh.tokenOwner[tokenID.Uint64()] = to | |||
There was a problem hiding this comment.
yes, please do a complete revisit of all the handlers, see if there are other places need to cover
There was a problem hiding this comment.
only handleTransferEvent need to update
| @@ -434,7 +434,15 @@ func (eh *contractStakingEventHandler) handleTransferEvent(event eventParam) err | |||
| return err | |||
| } | |||
|
|
|||
| eh.tokenOwner[tokenID.Uint64()] = to | |||
| token := tokenID.Uint64() | |||
| @@ -1715,6 +1715,62 @@ func TestContractStaking(t *testing.T) { | |||
| r.True(ok) | |||
| r.EqualValues(identityset.Address(delegateIdx).String(), bt.Candidate.String()) | |||
| }) | |||
|
|
|||
| t.Run("transfer token", func(t *testing.T) { | |||
There was a problem hiding this comment.
as we discussed, every newly added funcs/APIs should be covered by a test
envestcc
force-pushed
the
bugfix_transfer
branch
from
8452f22 to
5b99895
Compare
|
SonarCloud Quality Gate failed.
|
Description
Currently, only the transfer events triggered during the creation of a bucket are being handled. The transfer events triggered during subsequent bucket transfers are not being handled correctly.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: