change block creation subscription implementation #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CoderZhi
commented
Nov 10, 2018
CoderZhi
commented
- Delete channel
- Delete routine
- Implement Indexer and Server as subscribers
CoderZhi
force-pushed
the
stop_sub_chain_3
branch
from
898501e to
de1f7b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=========================================
+ Coverage 62.74% 62.8% +0.05%
=========================================
Files 110 110
Lines 11109 11081 -28
=========================================
- Hits 6970 6959 -11
+ Misses 3170 3153 -17
Partials 969 969
Continue to review full report at Codecov.
|
yutongp
reviewed
Nov 10, 2018
chainservice/chainservice.go
Outdated
| @@ -36,6 +36,7 @@ type ChainService struct { | |||
| explorer *explorer.Server | |||
| indexservice *indexservice.Server | |||
| protocols []Protocol | |||
| status bool | |||
golangcibot
reviewed
Nov 10, 2018
| handler <- blk | ||
| }(handler) | ||
| for _, s := range bc.blocklistener { | ||
| go func(bcs BlockCreationSubscriber, b *Block) { |
There was a problem hiding this comment.
(*blockchain).emitToSubscribers$1 - b is unused
server/itx/subchain.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (s *Server) startSubChainService(addr string, cs *chainservice.ChainService, blk *blockchain.Block) error { |
There was a problem hiding this comment.
(*Server).startSubChainService - blk is unused
dustinxie
reviewed
Nov 10, 2018
| if err := bcs.HandleBlock(blk); err != nil { | ||
| logger.Error().Err(err).Msg("Failed to handle new block") | ||
| } | ||
| }(s, blk) |
There was a problem hiding this comment.
no need to pass in 'blk'? as cibot commented above
zjshen14
reviewed
Nov 11, 2018
server/itx/server.go
Outdated
| initializedSubChains: map[uint32]bool{}, | ||
| } | ||
| if err := cs.Blockchain().AddSubscriber(&svr); err != nil { |
There was a problem hiding this comment.
Like the unsubscribe in the stop lifecycle event. Subscribe is better to be put into start lifecycle event.
server/itx/subchain.go
Outdated
| @@ -16,100 +16,81 @@ import ( | |||
| "github.com/iotexproject/iotex-core/action/protocols/multichain/mainchain" | |||
| "github.com/iotexproject/iotex-core/address" | |||
| "github.com/iotexproject/iotex-core/blockchain" | |||
| "github.com/iotexproject/iotex-core/chainservice" | |||
| "github.com/iotexproject/iotex-core/logger" | |||
| "github.com/iotexproject/iotex-core/pkg/routine" | |||
| ) | |||
|
|
|||
| func (s *Server) newSubChainStarter(protocol *mainchain.Protocol) *routine.RecurringTask { | |||
There was a problem hiding this comment.
Delete this function then?
server/itx/subchain.go
Outdated
| Msg("error when starting the sub-chain service") | ||
| } | ||
| } | ||
|
|
||
| }, | ||
| s.cfg.System.StartSubChainInterval, |
There was a problem hiding this comment.
Also, you can kill the config
CoderZhi
force-pushed
the
stop_sub_chain_3
branch
from
de1f7b1 to
fc690e2
Compare
golangcibot
reviewed
Nov 12, 2018
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| cs, ok := s.chainservices[chainID] |
CoderZhi
force-pushed
the
stop_sub_chain_3
branch
from
fc690e2 to
54482db
Compare
zjshen14
approved these changes
Nov 12, 2018
server/itx/server.go
Outdated
| initializedSubChains: map[uint32]bool{}, | ||
| } | ||
| if err := cs.Blockchain().AddSubscriber(&svr); err != nil { |
There was a problem hiding this comment.
Like the unsubscribe in the stop lifecycle event. Subscribe is better to be put into start lifecycle event.
yutongp
reviewed
Nov 13, 2018
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| cs, ok := s.chainservices[chainID] |
There was a problem hiding this comment.
if exist {
return cs, subChain, nil
}
CoderZhi
force-pushed
the
stop_sub_chain_3
branch
from
54482db to
527c889
Compare
CoderZhi
force-pushed
the
stop_sub_chain_3
branch
from
527c889 to
4870d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.